Skip to content

VPC: fix private mtu of vpc tier#10257

Merged
DaanHoogland merged 2 commits intoapache:4.19from
weizhouapache:4.19-fix-10001-vpc-tier-private-mtu
Mar 7, 2025
Merged

VPC: fix private mtu of vpc tier#10257
DaanHoogland merged 2 commits intoapache:4.19from
weizhouapache:4.19-fix-10001-vpc-tier-private-mtu

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Jan 23, 2025 •
edited
Loading

Description

This PR fixes #10001

Steps to reproduce the issue

  • update global setting for public/private mtu from 1500 to 1450
  • create vpc, the public/private mtu is 1450/1450
  • create vpc tier

expected result: public/private mtu is 1450/1450
actual result: public/private mtu is 1450/1500

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache linked an issue Jan 23, 2025 that may be closed by this pull request
Network uses the default mtu values if public/private mtu are not set #10001
Closed
@codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 15.14%. Comparing base (2075918) to head (74505a8).
Report is 64 commits behind head on 4.19.

Files with missing lines Patch % Lines
...ain/java/com/cloud/network/NetworkServiceImpl.java 0.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##               4.19   #10257    +/-   ##
==========================================
  Coverage     15.14%   15.14%            
- Complexity    11278    11313    +35     
==========================================
  Files          5408     5413     +5     
  Lines        473803   474709   +906     
  Branches      57819    57894    +75     
==========================================
+ Hits          71743    71911   +168     
- Misses       394039   394753   +714     
- Partials       8021     8045    +24
Flag Coverage Δ
uitests 4.29% <ø> (-0.01%) ⬇️
unittests 15.87% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland added this to the 4.19.2 milestone Jan 23, 2025
@DaanHoogland DaanHoogland modified the milestones: 4.19.2, 4.19.3 Feb 7, 2025
Pearl1594
Pearl1594 approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@Pearl1594
Copy link
Contributor

Pearl1594 commented Feb 26, 2025

@weizhouapache Could you please address the comment provided? Thanks.

@Pearl1594
Copy link
Contributor

Pearl1594 commented Feb 26, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Feb 26, 2025

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Feb 26, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12588

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Feb 27, 2025

@blueorangutan test keepEnv

@blueorangutan
Copy link

blueorangutan commented Feb 27, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@weizhouapache
Copy link
Member Author

weizhouapache commented Feb 27, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Feb 27, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Feb 27, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12600

@blueorangutan
Copy link

blueorangutan commented Feb 27, 2025

[SF] Trillian test result (tid-12504)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47731 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10257-t12504-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Mar 6, 2025

@weizhouapache is this ready for review/test/merge?

@weizhouapache weizhouapache marked this pull request as ready for review March 6, 2025 14:35
@weizhouapache
Copy link
Member Author

weizhouapache commented Mar 6, 2025

@weizhouapache is this ready for review/test/merge?

yes @DaanHoogland

DaanHoogland
DaanHoogland approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified in lab env

@DaanHoogland DaanHoogland merged commit 1f0ffee into apache:4.19 Mar 7, 2025
25 of 26 checks passed
@DaanHoogland DaanHoogland deleted the 4.19-fix-10001-vpc-tier-private-mtu branch March 7, 2025 14:07
@weizhouapache
Copy link
Member Author

weizhouapache commented Mar 7, 2025

verified in lab env

great. thanks @DaanHoogland !

@Pearl1594 Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025
@weizhouapache weizhouapache mentioned this pull request Apr 14, 2025
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@weizhouapache @dhslove
VPC: fix private mtu of vpc tier (apache#10257)
eed6573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

Assignees

No one assigned

Labels

component:networking

Projects

ACS 4.20.1
Status: Done

Milestone

4.19.3

Development

Successfully merging this pull request may close these issues.

Network uses the default mtu values if public/private mtu are not set

4 participants

@weizhouapache @Pearl1594 @blueorangutan @DaanHoogland